<html>
<head><meta charset="utf-8"><title>Updated Comparison UI · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html">Updated Comparison UI</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="246161294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161294">(Jul 15 2021 at 21:52)</a>:</h4>
<p>Somehow ended up working on the comparison page UI. <a href="https://github.com/rust-lang/rustc-perf/pull/914">https://github.com/rust-lang/rustc-perf/pull/914</a></p>
<p>Let me know what you think</p>
<p><a href="/user_uploads/4715/80wK970GXo9LDtVehQ24yKWb/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/80wK970GXo9LDtVehQ24yKWb/image.png" title="image.png"><img src="/user_uploads/4715/80wK970GXo9LDtVehQ24yKWb/image.png"></a></div>



<a name="246161396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161396">(Jul 15 2021 at 21:53)</a>:</h4>
<p>I think we should try to use less vertical screen real estate for the commits -- which most people don't need to change (they're following a direct link) -- and instead expand the filters</p>



<a name="246161669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161669">(Jul 15 2021 at 21:56)</a>:</h4>
<p>Definitely can see making the commits smaller. Not sure if the filter being open makes sense by default. I rarely filter though….</p>



<a name="246161759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161759">(Jul 15 2021 at 21:57)</a>:</h4>
<p>I can also see the filters section expanding pretty dramatically which is a reason both for and against having expanded by default IMO</p>



<a name="246161834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161834">(Jul 15 2021 at 21:58)</a>:</h4>
<p>I filter 99% of the time I visit a comparison page</p>



<a name="246161838"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161838" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161838">(Jul 15 2021 at 21:58)</a>:</h4>
<p>usually to check incr vs non incr and such</p>



<a name="246161860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161860">(Jul 15 2021 at 21:58)</a>:</h4>
<p>(and more rarely check vs debug vs opt)</p>



<a name="246161913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161913">(Jul 15 2021 at 21:59)</a>:</h4>
<p>Ok - I think if we open it by default and move the description of what the cache stats are to tooltips, that could be really nice</p>



<a name="246161929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246161929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246161929">(Jul 15 2021 at 21:59)</a>:</h4>
<p>I think tooltips are not very discoverable unfortunately</p>



<a name="246162014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246162014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246162014">(Jul 15 2021 at 22:00)</a>:</h4>
<p>maybe linkify and move the descriptions to the help page though?</p>



<a name="246162079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246162079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246162079">(Jul 15 2021 at 22:00)</a>:</h4>
<p>e.g., we could have filters which are pretty short and then a "Read the <a href="http://...">help</a> page for details on what these buttons mean!"</p>



<a name="246162235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246162235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246162235">(Jul 15 2021 at 22:02)</a>:</h4>
<p>Hmm you don't think something like this would be obvious?<br>
<a href="/user_uploads/4715/3CGKLXtzBbrOQG_LQ59KgwUc/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/3CGKLXtzBbrOQG_LQ59KgwUc/image.png" title="image.png"><img src="/user_uploads/4715/3CGKLXtzBbrOQG_LQ59KgwUc/image.png"></a></div>



<a name="246162353"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246162353" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246162353">(Jul 15 2021 at 22:03)</a>:</h4>
<p>oh, that would work</p>



<a name="246162375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246162375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246162375">(Jul 15 2021 at 22:03)</a>:</h4>
<p>I thought you meant just the "built in" tooltip, which gives no visible indication it exists unless you discover it</p>



<a name="246162488"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246162488" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246162488">(Jul 15 2021 at 22:04)</a>:</h4>
<p>Ah sorry no. Should have been more specific <span aria-label="blush" class="emoji emoji-1f60a" role="img" title="blush">:blush:</span></p>



<a name="246164018"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246164018" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246164018">(Jul 15 2021 at 22:25)</a>:</h4>
<p><a href="/user_uploads/4715/1ffpRjcbdhyLCJ6Fa6NRIKxA/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/1ffpRjcbdhyLCJ6Fa6NRIKxA/image.png" title="image.png"><img src="/user_uploads/4715/1ffpRjcbdhyLCJ6Fa6NRIKxA/image.png"></a></div>



<a name="246164028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246164028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246164028">(Jul 15 2021 at 22:25)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> ^^ thoughts?</p>



<a name="246164145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246164145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246164145">(Jul 15 2021 at 22:27)</a>:</h4>
<p>Seems great!</p>



<a name="246164158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246164158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246164158">(Jul 15 2021 at 22:27)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> ^</p>



<a name="246164839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246164839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246164839">(Jul 15 2021 at 22:36)</a>:</h4>
<p><a href="/user_uploads/4715/zlK2guan0b6eEqozOuQLfwyM/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/zlK2guan0b6eEqozOuQLfwyM/image.png" title="image.png"><img src="/user_uploads/4715/zlK2guan0b6eEqozOuQLfwyM/image.png"></a></div>



<a name="246164983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246164983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246164983">(Jul 15 2021 at 22:38)</a>:</h4>
<p>I've even tried collapsing the "search functionality". It doesn't work 100% as well I'd like but I'd like to update the top and have a header like:<br>
"Comparing 32aef21 to 238defa"</p>



<a name="246165263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246165263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246165263">(Jul 15 2021 at 22:42)</a>:</h4>
<p>Hm, we already have that just above the columns though?</p>



<a name="246165287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246165287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246165287">(Jul 15 2021 at 22:43)</a>:</h4>
<p>not opposed to another line but not sure I quite see the point</p>



<a name="246165420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246165420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246165420">(Jul 15 2021 at 22:44)</a>:</h4>
<p>Yea... it could be that that just needs to be improved - it honestly took me weeks to even see that line</p>



<a name="246165432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246165432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246165432">(Jul 15 2021 at 22:45)</a>:</h4>
<p>We can play with it</p>



<a name="246165518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246165518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246165518">(Jul 15 2021 at 22:46)</a>:</h4>
<p>huh</p>



<a name="246165532"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246165532" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246165532">(Jul 15 2021 at 22:46)</a>:</h4>
<p>yeah, maybe we can put the emphasis on commits not dates or something</p>



<a name="246165863"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246165863" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246165863">(Jul 15 2021 at 22:50)</a>:</h4>
<p>heh I also have wanted to put more emphasis on the commits being benchmarked before <a href="/user_uploads/4715/AJ_ML0eoAhMJDzmWTSaeSt8W/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/AJ_ML0eoAhMJDzmWTSaeSt8W/image.png" title="image.png"><img src="/user_uploads/4715/AJ_ML0eoAhMJDzmWTSaeSt8W/image.png"></a></div>



<a name="246166233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246166233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246166233">(Jul 15 2021 at 22:55)</a>:</h4>
<p>I also think that repeating information on a page is not bad. Sometimes it's helpful.</p>



<a name="246166255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246166255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246166255">(Jul 15 2021 at 22:55)</a>:</h4>
<p><a href="/user_uploads/4715/m5S6WzI8ryBbjwIRXO1gLlvG/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/m5S6WzI8ryBbjwIRXO1gLlvG/image.png" title="image.png"><img src="/user_uploads/4715/m5S6WzI8ryBbjwIRXO1gLlvG/image.png"></a></div>



<a name="246166374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246166374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246166374">(Jul 15 2021 at 22:56)</a>:</h4>
<p>With that layout, by default you see a few more of the benchmarks than the current layout too which is nice</p>



<a name="246166504"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246166504" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246166504">(Jul 15 2021 at 22:58)</a>:</h4>
<p>To be clear, totally fine repeating information -- mostly want to avoid wasting vertical screen real estate (which means you need to scroll to see more benchmarks, seems not great)</p>



<a name="246166518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246166518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246166518">(Jul 15 2021 at 22:58)</a>:</h4>
<p>to some extent it's possible the auto-filtering to remove noise will remove that as a "problem"</p>



<a name="246166697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246166697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246166697">(Jul 15 2021 at 23:00)</a>:</h4>
<p>Oh absolutely. I agree with you on the not losing real estate front. But after this PR we'll be gaining real-estate so we're making positive progress :-)</p>



<a name="246167202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246167202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246167202">(Jul 15 2021 at 23:06)</a>:</h4>
<p>a niche feature that I would have found useful a few times: generate shell commands to download the builds and then run them locally. e.g. to reproduce a benchmark under perf to see what changed.</p>



<a name="246167983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246167983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246167983">(Jul 15 2021 at 23:17)</a>:</h4>
<p><span class="user-mention" data-user-id="330154">@The 8472</span> feel free to file an issue!</p>



<a name="246168011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246168011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246168011">(Jul 15 2021 at 23:17)</a>:</h4>
<p>Ok done with the UI changes for now. Feel free to merge them if you want or to give any more feedback <span aria-label="blush" class="emoji emoji-1f60a" role="img" title="blush">:blush:</span></p>



<a name="246168469"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246168469" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246168469">(Jul 15 2021 at 23:24)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> emphasizing the PR number vs opaque commit hashes might be another good idea, fwiw</p>



<a name="246168479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246168479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246168479">(Jul 15 2021 at 23:24)</a>:</h4>
<p>Both are a little opaque though.</p>



<a name="246168504"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246168504" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246168504">(Jul 15 2021 at 23:25)</a>:</h4>
<p>(though for local comparisons we only have the artifact id, so we should make sure that works well too.)</p>



<a name="246195830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246195830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246195830">(Jul 16 2021 at 08:10)</a>:</h4>
<p>I also use filtering almost all of the time. I'd prefer if it wasn't hidden by default. It can be made pretty compact though, right?</p>



<a name="246195891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246195891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246195891">(Jul 16 2021 at 08:11)</a>:</h4>
<p><span class="user-mention" data-user-id="124287">@mw</span> we no longer collapse filtering by default. Checkout the PR for the latest screenshots</p>



<a name="246196209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246196209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246196209">(Jul 16 2021 at 08:15)</a>:</h4>
<p>It still looks like things are taking up a bit more space than necessary.</p>



<a name="246196309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246196309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246196309">(Jul 16 2021 at 08:16)</a>:</h4>
<p>e.g. the collapsed filters box is as big as I would expect it to ever get in uncollapsed state :)</p>



<a name="246196331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246196331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246196331">(Jul 16 2021 at 08:16)</a>:</h4>
<p>So my priorities are clarity over space efficiency. We can certainly try to make things tighter (happy to continue to riff on that), but as things stand, more benchmarks are visible after this change than are currently visible.</p>



<a name="246196839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246196839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246196839">(Jul 16 2021 at 08:23)</a>:</h4>
<p><a href="/user_uploads/4715/Y05s_xZn7B4oVVcGbP5tqX0O/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/Y05s_xZn7B4oVVcGbP5tqX0O/image.png" title="image.png"><img src="/user_uploads/4715/Y05s_xZn7B4oVVcGbP5tqX0O/image.png"></a></div>



<a name="246196898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246196898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246196898">(Jul 16 2021 at 08:24)</a>:</h4>
<p>I think clarity and space efficiency go hand in hand to some degree</p>



<a name="246196924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246196924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246196924">(Jul 16 2021 at 08:24)</a>:</h4>
<p>at least their are not completely at odds with each other :)</p>



<a name="246197034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246197034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246197034">(Jul 16 2021 at 08:26)</a>:</h4>
<p>The picture is a quick mockup of how small I think the filters box could be</p>



<a name="246197313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246197313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246197313">(Jul 16 2021 at 08:30)</a>:</h4>
<p>maybe a separate commit and date input would make sense, then the latter could have a date picker</p>



<a name="246203832"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246203832" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246203832">(Jul 16 2021 at 09:49)</a>:</h4>
<p><a href="/user_uploads/4715/k2QnX4PZbUT8JATx785cdoho/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/k2QnX4PZbUT8JATx785cdoho/image.png" title="image.png"><img src="/user_uploads/4715/k2QnX4PZbUT8JATx785cdoho/image.png"></a></div>



<a name="246203850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246203850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246203850">(Jul 16 2021 at 09:49)</a>:</h4>
<p><span class="user-mention" data-user-id="124287">@mw</span> thoughts? I really need to work on something else <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span></p>



<a name="246203866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246203866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246203866">(Jul 16 2021 at 09:49)</a>:</h4>
<p>What is it called when you nerd snipe yourself?</p>



<a name="246203930"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246203930" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246203930">(Jul 16 2021 at 09:50)</a>:</h4>
<p>(the first section is collapsed by default)</p>



<a name="246203941"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246203941" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246203941">(Jul 16 2021 at 09:50)</a>:</h4>
<p>Default view:<br>
<a href="/user_uploads/4715/3Q2kubLVVzVOiYpvheqkYDrY/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/3Q2kubLVVzVOiYpvheqkYDrY/image.png" title="image.png"><img src="/user_uploads/4715/3Q2kubLVVzVOiYpvheqkYDrY/image.png"></a></div>



<a name="246204096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246204096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246204096">(Jul 16 2021 at 09:52)</a>:</h4>
<p><span class="user-mention silent" data-user-id="330154">The 8472</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Updated.20Comparison.20UI/near/246197313">said</a>:</p>
<blockquote>
<p>maybe a separate commit and date input would make sense, then the latter could have a date picker</p>
</blockquote>
<p>It's either a commit OR a date so I wouldn't do two independent pickers as that's likely confusing. But maybe a way to switch between plain text input and a data picker?</p>



<a name="246206163"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246206163" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246206163">(Jul 16 2021 at 10:19)</a>:</h4>
<p><span class="user-mention silent" data-user-id="224872">rylev</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Updated.20Comparison.20UI/near/246203866">said</a>:</p>
<blockquote>
<p>What is it called when you nerd snipe yourself?</p>
</blockquote>
<p>nerd sniped yourself in the foot?</p>



<a name="246206333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246206333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246206333">(Jul 16 2021 at 10:21)</a>:</h4>
<p>Looks good, except that I think the "metric" selection should be visible by default. It also doesn't clearly belong into the "compare other commits" section, right?</p>



<a name="246206406"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246206406" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246206406">(Jul 16 2021 at 10:22)</a>:</h4>
<p>It does. You have to resubsmit the form in order to get results for another metric</p>



<a name="246206424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246206424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246206424">(Jul 16 2021 at 10:22)</a>:</h4>
<p>Perhaps the label should be changed then...</p>



<a name="246206563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246206563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246206563">(Jul 16 2021 at 10:24)</a>:</h4>
<p>Maybe "Do another comparison"</p>



<a name="246207041"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246207041" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246207041">(Jul 16 2021 at 10:30)</a>:</h4>
<p>Pushed that as a change</p>



<a name="246465220"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246465220" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246465220">(Jul 19 2021 at 14:54)</a>:</h4>
<p>Are the test cases not supposed to be collapsed (or even collapsible) anymore? If so, that's fine, it's just the current behavior seems kind of like a bug to me.</p>
<p><a href="/user_uploads/4715/KlMTUU3vyCV0YfDpgi7ow2SI/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/KlMTUU3vyCV0YfDpgi7ow2SI/image.png" title="image.png"><img src="/user_uploads/4715/KlMTUU3vyCV0YfDpgi7ow2SI/image.png"></a></div>



<a name="246465331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246465331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246465331">(Jul 19 2021 at 14:55)</a>:</h4>
<p>Hm - <span class="user-mention" data-user-id="224872">@rylev</span> I think the page is just broken? I'm seeing:</p>
<p><a href="/user_uploads/4715/OK21VnpaFdfH7NH0Y3ZdCDdP/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/OK21VnpaFdfH7NH0Y3ZdCDdP/image.png" title="image.png"><img src="/user_uploads/4715/OK21VnpaFdfH7NH0Y3ZdCDdP/image.png"></a></div>



<a name="246465346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246465346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246465346">(Jul 19 2021 at 14:55)</a>:</h4>
<p>on just <a href="https://perf.rust-lang.org/compare.html">https://perf.rust-lang.org/compare.html</a></p>



<a name="246465481"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246465481" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246465481">(Jul 19 2021 at 14:56)</a>:</h4>
<p>and we seem to have entirely lost the bootstrap data</p>



<a name="246465502"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246465502" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246465502">(Jul 19 2021 at 14:56)</a>:</h4>
<p>Oh, I see the screenshot on <a href="https://github.com/rust-lang/rustc-perf/pull/914">https://github.com/rust-lang/rustc-perf/pull/914</a> looks like what I'm seeing so I think that's intended.</p>



<a name="246465747"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246465747" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246465747">(Jul 19 2021 at 14:58)</a>:</h4>
<p>I wonder if aligning the test names on the same line as the first test case would make it a bit easier to skim. As it is, I have to parse each line a bit to find the next test case. By putting the test names in a different column, it makes it easier to read at a glance (imo). </p>
<p><a href="/user_uploads/4715/ShRnu6DBh3HDJmIWT8y1St8U/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/ShRnu6DBh3HDJmIWT8y1St8U/image.png" title="image.png"><img src="/user_uploads/4715/ShRnu6DBh3HDJmIWT8y1St8U/image.png"></a></div>



<a name="246471620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246471620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246471620">(Jul 19 2021 at 15:38)</a>:</h4>
<p>Sorry y'all! I'll get this fixed right away</p>



<a name="246471690"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246471690" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246471690">(Jul 19 2021 at 15:38)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> yes, I'm trying expanded by default. With the behavior of not showing "insignificant" changes, it seemed like the right way to go. I'm guessing you like the old behavior better?</p>



<a name="246471785"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246471785" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246471785">(Jul 19 2021 at 15:39)</a>:</h4>
<p>I can certainly do your suggestion</p>



<a name="246471822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246471822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246471822">(Jul 19 2021 at 15:40)</a>:</h4>
<p>I think I'm mostly just feeling "it's different". Overall I think the change is positive.</p>



<a name="246471977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246471977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246471977">(Jul 19 2021 at 15:41)</a>:</h4>
<p>The change I suggested would help me but I don't know if it's actually useful for others.</p>



<a name="246472034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246472034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246472034">(Jul 19 2021 at 15:41)</a>:</h4>
<p>I think it's a good suggestion</p>



<a name="246473983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246473983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246473983">(Jul 19 2021 at 15:57)</a>:</h4>
<p>Here's a fix for the issue <span class="user-mention" data-user-id="116122">@simulacrum</span> reported: <a href="https://github.com/rust-lang/rustc-perf/pull/920">https://github.com/rust-lang/rustc-perf/pull/920</a></p>



<a name="246474039"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246474039" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246474039">(Jul 19 2021 at 15:57)</a>:</h4>
<p>I had tested that case but then introduced that bug on a clean up commit without retesting <span aria-label="sad" class="emoji emoji-2639" role="img" title="sad">:sad:</span></p>



<a name="246474223"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246474223" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246474223">(Jul 19 2021 at 15:59)</a>:</h4>
<p>These fixes use the newish null operators <code>?</code> and <code>??</code> in JavaScript. It's been supported in all browsers since early 2020 so I figure it's probably fine to use.</p>



<a name="246474702"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246474702" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246474702">(Jul 19 2021 at 16:02)</a>:</h4>
<p>Ah bootstrap is still missing on that page for some reason. Looking now</p>



<a name="246476921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246476921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246476921">(Jul 19 2021 at 16:19)</a>:</h4>
<p>Merged that fix for now</p>



<a name="246477745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246477745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246477745">(Jul 19 2021 at 16:27)</a>:</h4>
<p>Thanks - had to pop into a meeting</p>



<a name="246477757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246477757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246477757">(Jul 19 2021 at 16:27)</a>:</h4>
<p>I know what the other issue is</p>



<a name="246478142"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246478142" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246478142">(Jul 19 2021 at 16:30)</a>:</h4>
<p><a href="https://github.com/rust-lang/rustc-perf/pull/921">https://github.com/rust-lang/rustc-perf/pull/921</a></p>



<a name="246483606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246483606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246483606">(Jul 19 2021 at 17:12)</a>:</h4>
<p><span class="user-mention" data-user-id="125250">@Wesley Wiser</span> <span class="user-mention" data-user-id="116122">@simulacrum</span> Thoughts on this?<br>
<a href="/user_uploads/4715/wHhxMPiSD2zdog9awqrFoA8b/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/wHhxMPiSD2zdog9awqrFoA8b/image.png" title="image.png"><img src="/user_uploads/4715/wHhxMPiSD2zdog9awqrFoA8b/image.png"></a></div>



<a name="246483887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246483887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246483887">(Jul 19 2021 at 17:15)</a>:</h4>
<p>hm, feels a little noisy I guess -- I wonder if we should try instead to have sort of different "modes/group by" -- all together, sorted purely by %change (does not group by benchmark + mode); by mode (puts all opt together, then all check, etc.) ... something like that?</p>



<a name="246483902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246483902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246483902">(Jul 19 2021 at 17:15)</a>:</h4>
<p>but not really opposed necessarily</p>



<a name="246483933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246483933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246483933">(Jul 19 2021 at 17:15)</a>:</h4>
<p>(I have strong bias towards "the old version was fine" so hard for me to make good assessments I think)</p>



<a name="246484051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246484051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246484051">(Jul 19 2021 at 17:16)</a>:</h4>
<p><span class="user-mention silent" data-user-id="224872">rylev</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Updated.20Comparison.20UI/near/246483606">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="125250">Wesley Wiser</span> <span class="user-mention silent" data-user-id="116122">simulacrum</span> Thoughts on this?<br>
<a href="/user_uploads/4715/wHhxMPiSD2zdog9awqrFoA8b/image.png">image.png</a></p>
</blockquote>
<p>I think that's an improvement over the current version so <span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span> from me.</p>



<a name="246484114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246484114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246484114">(Jul 19 2021 at 17:17)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Updated.20Comparison.20UI/near/246483933">said</a>:</p>
<blockquote>
<p>(I have strong bias towards "the old version was fine" so hard for me to make good assessments I think)</p>
</blockquote>
<p>We could also go back to the old version. Not against the idea that I'm the only one who had difficulties with it</p>



<a name="246484255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246484255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246484255">(Jul 19 2021 at 17:18)</a>:</h4>
<p>This new version is less noisy IMO than the old version except that this has everything expanded by default</p>



<a name="246484503"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246484503" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246484503">(Jul 19 2021 at 17:20)</a>:</h4>
<p>Here's the old version (when expanded):<br>
<a href="/user_uploads/4715/z4cEj1nKgT90kYcjZ3jYKafO/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/z4cEj1nKgT90kYcjZ3jYKafO/image.png" title="image.png"><img src="/user_uploads/4715/z4cEj1nKgT90kYcjZ3jYKafO/image.png"></a></div>



<a name="246484606"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246484606" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246484606">(Jul 19 2021 at 17:21)</a>:</h4>
<p>The center alignment of the benchmark names makes it more difficult to parse for me, it doesn't follow a grid.</p>



<a name="246484638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246484638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246484638">(Jul 19 2021 at 17:21)</a>:</h4>
<p>the old one had the advantage of clearly separating the benchmark name, while the new one is kinda hidden among the data, and being tightly spaced vertically (and with equal spacing above and below the benchmark name) makes it a bit harder to know whether the benchark name is before or after the data</p>



<a name="246485081"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246485081" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246485081">(Jul 19 2021 at 17:24)</a>:</h4>
<p><span class="user-mention silent" data-user-id="330154">The 8472</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Updated.20Comparison.20UI/near/246484606">said</a>:</p>
<blockquote>
<p>The center alignment of the benchmark names makes it more difficult to parse for me, it doesn't follow a grid.</p>
</blockquote>
<p>Yea but the grid is actually kind of misleading as the min, max and avg cells don't correspond to the columns they're in</p>



<a name="246485133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246485133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246485133">(Jul 19 2021 at 17:25)</a>:</h4>
<p>That always made it hard for me to parse. The rows look the same, but are displaying totally different info</p>



<a name="246485276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246485276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246485276">(Jul 19 2021 at 17:26)</a>:</h4>
<p><span class="user-mention" data-user-id="116113">@lqd</span> hmm can you explain more. I actually think the direct opposite. The benchmark name in the new version is distinct from the date instead of being "just another cell" in the old version</p>



<a name="246486083"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246486083" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246486083">(Jul 19 2021 at 17:32)</a>:</h4>
<p>when scanning quickly, it could be lost among the data <a href="/user_uploads/4715/_TE1Ex2qBkwUy-C-tN-AMzVu/image.png">image.png</a> -- in this cropped version of your screenshot, there's no difference in spacing, or objects being closer to others so it makes less use of "the gestalt principle of proximity" to know whether it's about the data above or below it</p>
<div class="message_inline_image"><a href="/user_uploads/4715/_TE1Ex2qBkwUy-C-tN-AMzVu/image.png" title="image.png"><img src="/user_uploads/4715/_TE1Ex2qBkwUy-C-tN-AMzVu/image.png"></a></div>



<a name="246486546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246486546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246486546">(Jul 19 2021 at 17:36)</a>:</h4>
<p>(there's generally plenty of space on the sides of this table, if needed it could be used to make the benchmark name clearer and isolated, to also be able to scan it quickly -- which is also hindered by it being centered as the 8472 mentioned)</p>



<a name="246486995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246486995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246486995">(Jul 19 2021 at 17:39)</a>:</h4>
<p>What about this:<br>
<a href="/user_uploads/4715/vp-T94pu7Iam_aDKGv9fS5Ts/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/vp-T94pu7Iam_aDKGv9fS5Ts/image.png" title="image.png"><img src="/user_uploads/4715/vp-T94pu7Iam_aDKGv9fS5Ts/image.png"></a></div>



<a name="246487402"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246487402" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246487402">(Jul 19 2021 at 17:43)</a>:</h4>
<p>It might make sense to put a border between the name and the sub-benchmarks to make it immediately clear what the span covered by the name is. And I assume it doesn't line-break on larger screens.</p>



<a name="246487544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246487544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246487544">(Jul 19 2021 at 17:44)</a>:</h4>
<p>is that just when the benchmarks are expanded btw ?</p>



<a name="246487601"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246487601" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246487601">(Jul 19 2021 at 17:45)</a>:</h4>
<p>(that is, are the min/max still present when they're collapsed ?)</p>



<a name="246487648"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246487648" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246487648">(Jul 19 2021 at 17:45)</a>:</h4>
<p><a href="/user_uploads/4715/BqKR5zGq93d5P7XCZj-Sc8T8/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/BqKR5zGq93d5P7XCZj-Sc8T8/image.png" title="image.png"><img src="/user_uploads/4715/BqKR5zGq93d5P7XCZj-Sc8T8/image.png"></a></div>



<a name="246487688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246487688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246487688">(Jul 19 2021 at 17:45)</a>:</h4>
<p><span class="user-mention" data-user-id="116113">@lqd</span> currently they cannot be collapsed.</p>



<a name="246487789"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246487789" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246487789">(Jul 19 2021 at 17:46)</a>:</h4>
<p>currently as in "in your in-progress work" or currently on perf.rlo ?</p>



<a name="246487853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246487853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246487853">(Jul 19 2021 at 17:47)</a>:</h4>
<p>Currently on perf.rlo (since the latest change) - but the latest change also only shows "significant" changes now</p>



<a name="246487881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246487881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246487881">(Jul 19 2021 at 17:47)</a>:</h4>
<p>So there's also just a lot less data typically</p>



<a name="246488033"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246488033" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246488033">(Jul 19 2021 at 17:48)</a>:</h4>
<p>ah I assumed that the toggle triangle currently showing <a href="/user_uploads/4715/6ngQwks0-8OJg0I_QOuQf34z/image.png">image.png</a> and which doesn't collapse/expand rn was a temporary bug</p>
<div class="message_inline_image"><a href="/user_uploads/4715/6ngQwks0-8OJg0I_QOuQf34z/image.png" title="image.png"><img src="/user_uploads/4715/6ngQwks0-8OJg0I_QOuQf34z/image.png"></a></div>



<a name="246488126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246488126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246488126">(Jul 19 2021 at 17:49)</a>:</h4>
<p>It's a visual bug (as in the toggle indicator should not be there)</p>



<a name="246488183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246488183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246488183">(Jul 19 2021 at 17:49)</a>:</h4>
<p>yeah I understood that ^^</p>



<a name="246488243"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246488243" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246488243">(Jul 19 2021 at 17:50)</a>:</h4>
<p>But I'm happy to re-interpret it as another kind of bug if people think the toggling is essential</p>



<a name="246488910"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246488910" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246488910">(Jul 19 2021 at 17:54)</a>:</h4>
<p>fun to see others' takes on the same problems. I went the opposite direction in a prototype a while back, by trying to focus on summaries/filtering (but didn't go far enough in this direction anyways) to extract some signal from the many results, before drilling in a given run <a href="https://lqd.github.io/perf/report.html">https://lqd.github.io/perf/report.html</a></p>



<a name="246489013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246489013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246489013">(Jul 19 2021 at 17:55)</a>:</h4>
<p>The issue might be that we should just treat all benchmark runs as separate and stop grouping by the benchmark name. This is just a hold over for how it was done in the past</p>



<a name="246489191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246489191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246489191">(Jul 19 2021 at 17:56)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116113">lqd</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Updated.20Comparison.20UI/near/246488910">said</a>:</p>
<blockquote>
<p>fun to see others' takes on the same problems. I went the opposite direction in a prototype a while back, by trying to focus on summaries/filtering (but didn't go far enough in this direction anyways) to extract some signal from the many results, before drilling in a given run <a href="https://lqd.github.io/perf/report.html">https://lqd.github.io/perf/report.html</a></p>
</blockquote>
<p>This is really cool! I'd love to work with you on continuing to evolve this. The changes that just happened were really more for getting certain technical pieces in place. We can keep fine tuning it</p>



<a name="246489224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246489224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246489224">(Jul 19 2021 at 17:57)</a>:</h4>
<p>Specifically I love the summary portions you have. I really want to add that.</p>



<a name="246489460"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246489460" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246489460">(Jul 19 2021 at 17:59)</a>:</h4>
<p>I feel like I remember mw writing some GH issues about perf.rlo uses cases, improvements, the kinds of summary data they were looking for -- as possible improvements to the status quo back then; some of which was implemented</p>



<a name="246489708"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246489708" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246489708">(Jul 19 2021 at 18:00)</a>:</h4>
<p>feel free to steal what you like from this thing</p>



<a name="246504118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246504118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246504118">(Jul 19 2021 at 19:45)</a>:</h4>
<p><a href="/user_uploads/4715/3x34elXhTJ7dEjQ0tKTNi8sw/Screenshot_20210719-144410.jpg">Screenshot_20210719-144410.jpg</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/3x34elXhTJ7dEjQ0tKTNi8sw/Screenshot_20210719-144410.jpg" title="Screenshot_20210719-144410.jpg"><img src="/user_uploads/4715/3x34elXhTJ7dEjQ0tKTNi8sw/Screenshot_20210719-144410.jpg"></a></div>



<a name="246504131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246504131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246504131">(Jul 19 2021 at 19:45)</a>:</h4>
<p>The new overlay is overlapping in mobile:</p>



<a name="246508034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246508034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246508034">(Jul 19 2021 at 20:15)</a>:</h4>
<p><span class="user-mention" data-user-id="125294">@Aaron Hill</span> whoops sorry! I will get that fixed tomorrow.</p>



<a name="246562918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246562918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246562918">(Jul 20 2021 at 09:31)</a>:</h4>
<p><a href="/user_uploads/4715/4wJScfykqRakLy7Aiq0XllRJ/5FC46B51-D4F7-41EA-9E8B-A11AFCCB848F.jpg">5FC46B51-D4F7-41EA-9E8B-A11AFCCB848F.jpg</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/4wJScfykqRakLy7Aiq0XllRJ/5FC46B51-D4F7-41EA-9E8B-A11AFCCB848F.jpg" title="5FC46B51-D4F7-41EA-9E8B-A11AFCCB848F.jpg"><img src="/user_uploads/4715/4wJScfykqRakLy7Aiq0XllRJ/5FC46B51-D4F7-41EA-9E8B-A11AFCCB848F.jpg"></a></div>



<a name="246562939"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246562939" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246562939">(Jul 20 2021 at 09:31)</a>:</h4>
<p>Not perfect but definitely more readable</p>



<a name="246565736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246565736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246565736">(Jul 20 2021 at 10:06)</a>:</h4>
<p>Hm, I personally prefer to see many entries at a glance rather than just a few with it fully on screen</p>



<a name="246565747"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246565747" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246565747">(Jul 20 2021 at 10:06)</a>:</h4>
<p>(and can pinch/zoom to get the name)</p>



<a name="246568369"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246568369" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246568369">(Jul 20 2021 at 10:40)</a>:</h4>
<p>Here's what it used to look like:<br>
<a href="/user_uploads/4715/j48UFju0iETjGo4inw8WDMmO/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/j48UFju0iETjGo4inw8WDMmO/image.png" title="image.png"><img src="/user_uploads/4715/j48UFju0iETjGo4inw8WDMmO/image.png"></a></div>



<a name="246568427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246568427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246568427">(Jul 20 2021 at 10:41)</a>:</h4>
<p>So we haven't really lost much information density.</p>



<a name="246568481"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246568481" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246568481">(Jul 20 2021 at 10:42)</a>:</h4>
<p>We could make the names of the benchmark name smaller</p>



<a name="246569326"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246569326" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246569326">(Jul 20 2021 at 10:54)</a>:</h4>
<p>Something like this:<br>
<a href="/user_uploads/4715/gxAtvlRy-U307Dv1EfXNMzsm/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/gxAtvlRy-U307Dv1EfXNMzsm/image.png" title="image.png"><img src="/user_uploads/4715/gxAtvlRy-U307Dv1EfXNMzsm/image.png"></a></div>



<a name="246569782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246569782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246569782">(Jul 20 2021 at 11:00)</a>:</h4>
<p>is this grid or table layout? with grid you could probably switch to labels on top for mobile and on the left for wider screens.</p>



<a name="246569880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246569880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246569880">(Jul 20 2021 at 11:01)</a>:</h4>
<p>ah table, then that would be more difficult</p>



<a name="246570083"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246570083" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246570083">(Jul 20 2021 at 11:03)</a>:</h4>
<p>Yea I'm thinking about switching to grid.</p>



<a name="246570155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246570155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246570155">(Jul 20 2021 at 11:04)</a>:</h4>
<p>I'd like to stop working on this for now. I'm of the personal opinion that the state we're in is an improvement over what was there before. I'm happy to keep going if people disagree, but if not, I'd like to focus on non-UI for a while</p>



<a name="246570177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246570177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246570177">(Jul 20 2021 at 11:05)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> ^^ opinions on whether we've regressed with compared to the pre-vue.js UI?</p>



<a name="246570204"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246570204" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246570204">(Jul 20 2021 at 11:05)</a>:</h4>
<p>I think it's fine to leave it as is</p>



<a name="246570240"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246570240" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246570240">(Jul 20 2021 at 11:06)</a>:</h4>
<p>I want to try it out for a bit at least before making assessments</p>



<a name="246633415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246633415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246633415">(Jul 20 2021 at 18:53)</a>:</h4>
<p>Thanks for working on this!  Just randomly ended up on a perf result and liked it.</p>



<a name="246851408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/246851408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#246851408">(Jul 22 2021 at 14:06)</a>:</h4>
<p>I haven’t reviewed the backlog of comments here, I just wanted to say: 1. Exciting work, and 2. I’m worried that the Summary line at the top might be interpreted as column labels. Maybe put it in its own box?</p>



<a name="247777987"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Updated%20Comparison%20UI/near/247777987" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tyson Nottingham <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Updated.20Comparison.20UI.html#247777987">(Jul 31 2021 at 01:23)</a>:</h4>
<p>I think that left or right alignment of the text in each of the columns would make the results a bit easier to scan.</p>
<p>Also, for numeric columns, I'm not sure it's of much use here, but right alignment can be helpful in that you can more easily see differences in magnitude between numbers.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>